From 8433689118e9f19795cf5270313ba21fd489d1c3 Mon Sep 17 00:00:00 2001 From: thomas_lucky13 Date: Wed, 7 Dec 2022 16:38:46 +0300 Subject: [PATCH] fix-videoSize-saving Videos placed in an OpenBoard document do not retain their adjusted size when the OpenBoard is closed. When preparing the document, the video is placed at the correct size, but when opened - the video area settings are reset to the default settings, which is unacceptable. The problem is solved by removing connect from UBGraphicsVideoItem with the nativeSizeChanged slot Fixes: https://github.com/OpenBoard-org/OpenBoard/issues/715 --- src/domain/UBGraphicsMediaItem.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/domain/UBGraphicsMediaItem.cpp b/src/domain/UBGraphicsMediaItem.cpp index 402a48da..4cc03928 100644 --- a/src/domain/UBGraphicsMediaItem.cpp +++ b/src/domain/UBGraphicsMediaItem.cpp @@ -144,8 +144,12 @@ UBGraphicsVideoItem::UBGraphicsVideoItem(const QUrl &pMediaFileUrl, QGraphicsIte setMinimumSize(QSize(320, 240)); setSize(320, 240); + /* + * I commented this to allow the video takes it's saved size + * connect(mVideoItem, SIGNAL(nativeSizeChanged(QSizeF)), this, SLOT(videoSizeChanged(QSizeF))); + */ connect(mMediaObject, SIGNAL(videoAvailableChanged(bool)), this, SLOT(hasVideoChanged(bool))); -- 2.33.5